CreatBot/CreatBotKlipper
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

command: Prefer uint8_t* for buffers; prefer uint8_fast_t for lengths

Browse Source 
Prefer using 'uint8_t' buffers as it is too easy to run into C sign
extension problems with 'char' buffers.  Prefer using 'uint_fast8_t'
for buffer lengths as gcc does a better job compiling them on 32bit
mcus.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This commit is contained in:
Kevin O'Connor
2018-05-24 12:49:23 -04:00
parent 2a55741ea8
commit cb4e165071
11 changed files with 71 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/linux/console.c
View File

@@ -128,7 +128,7 @@ console_setup(char *name)
****************************************************************/
static struct task_wake console_wake;
static char receive_buf[4096];
static uint8_t receive_buf[4096];
static int receive_pos;
// Process any incoming commands
@@ -155,7 +155,7 @@ console_task(void)
// Find and dispatch message blocks in the input
int len = receive_pos + ret;
uint8_t pop_count, msglen = len > MESSAGE_MAX ? MESSAGE_MAX : len;
uint_fast8_t pop_count, msglen = len > MESSAGE_MAX ? MESSAGE_MAX : len;
ret = command_find_block(receive_buf, msglen, &pop_count);
if (ret > 0)
command_dispatch(receive_buf, pop_count);
@@ -175,8 +175,8 @@ void
console_sendf(const struct command_encoder *ce, va_list args)
{
// Generate message
char buf[MESSAGE_MAX];
uint8_t msglen = command_encodef(buf, ce, args);
uint8_t buf[MESSAGE_MAX];
uint_fast8_t msglen = command_encodef(buf, ce, args);
command_add_frame(buf, msglen);
// Transmit message