CreatBot/CreatBotKlipperScreen
7
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "always unload panels fixes #932" and fix it in a different way

Browse Source 
it did not work as expected (#996) and caused other issues with macros and menus
del self.panels causes a memory leak
This commit is contained in:
alfrix 2023-06-07 14:25:49 -03:00
parent fa73daaf71
commit 1813533bec
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
screen.py
View File

@ -479,9 +479,6 @@ class KlipperScreen(Gtk.Window):
self._cur_panels = [] self._cur_panels = []
for _ in self.base_panel.content.get_children(): for _ in self.base_panel.content.get_children():
self.base_panel.content.remove(_) self.base_panel.content.remove(_)
for panel in list(self.panels):
if panel not in ["printer_select", "splash_screen"]:
del self.panels[panel]
for dialog in self.dialogs: for dialog in self.dialogs:
self.gtk.remove_dialog(dialog) self.gtk.remove_dialog(dialog)
self.close_screensaver() self.close_screensaver()
@ -496,7 +493,6 @@ class KlipperScreen(Gtk.Window):
if self._cur_panels[-1] in self.subscriptions: if self._cur_panels[-1] in self.subscriptions:
self.subscriptions.remove(self._cur_panels[-1]) self.subscriptions.remove(self._cur_panels[-1])
if pop: if pop:
del self.panels[self._cur_panels[-1]]
del self._cur_panels[-1] del self._cur_panels[-1]
self.attach_panel(self._cur_panels[-1]) self.attach_panel(self._cur_panels[-1])