CreatBot/CreatBotMoonraker
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

webcam: remove call to escape_url

Browse Source 
The configured url should already be escaped.  It isn't possible to
reliably quote a full url if any of the parts contain special characters.

Signed-off-by:  Eric Callahan <arksine.code@gmail.com>
This commit is contained in:
Eric Callahan 2023-02-11 07:49:06 -05:00
parent 5661b0216c
commit 0b4e604c95
No known key found for this signature in database
GPG Key ID: 5A1EB336DFB4C71B
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
moonraker/components/webcam.py
View File

@ -194,8 +194,8 @@ class WebcamManager:
except Exception: except Exception:
logging.exception(f"Error Processing {img_type} url") logging.exception(f"Error Processing {img_type} url")
result[f"{img_type}_url"] = "" result[f"{img_type}_url"] = ""
url: str = result["snapshot_url"]
if result.get("snapshot_url", "").startswith("http"): if result.get("snapshot_url", "").startswith("http"):
url = client.escape_url(result["snapshot_url"])
ret = await client.get(url, connect_timeout=1., request_timeout=1.) ret = await client.get(url, connect_timeout=1., request_timeout=1.)
result["snapshot_reachable"] = not ret.has_error() result["snapshot_reachable"] = not ret.has_error()
return result return result