From e986e3cd8eb32ddefbd9f3d014f6c3f3e3bce5bc Mon Sep 17 00:00:00 2001 From: alfrix Date: Mon, 22 Aug 2022 09:50:02 -0300 Subject: [PATCH] fix PEP8 E303 and make the code check more strict --- .github/workflows/test_code.yml | 4 ++-- ks_includes/functions.py | 3 --- panels/bed_mesh.py | 2 -- scripts/check_code.sh | 2 +- 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test_code.yml b/.github/workflows/test_code.yml index 1fd7bf54..0884504b 100644 --- a/.github/workflows/test_code.yml +++ b/.github/workflows/test_code.yml @@ -2,7 +2,7 @@ name: test-code on: [push, pull_request] jobs: lint-python-code: - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 - uses: ricardochaves/python-lint@v1.4.0 @@ -14,4 +14,4 @@ jobs: use-black: false use-mypy: false use-isort: false - extra-pycodestyle-options: "--ignore=E226,E301,E302,E303,E402,W503,W504 --max-line-length=120 --max-doc-length=120" + extra-pycodestyle-options: "--ignore=E402,W503,W504 --max-line-length=120 --max-doc-length=120" diff --git a/ks_includes/functions.py b/ks_includes/functions.py index 6c619f1b..150fe278 100644 --- a/ks_includes/functions.py +++ b/ks_includes/functions.py @@ -17,7 +17,6 @@ try: ctypes.cdll.LoadLibrary('libXext.so.6') libXext = ctypes.CDLL('libXext.so.6') - class DPMS_State: Fail = -1 On = 0 @@ -25,7 +24,6 @@ try: Suspend = 2 Off = 3 - def get_DPMS_state(display_name_in_byte_string=b':0'): state = DPMS_State.Fail if not isinstance(display_name_in_byte_string, bytes): @@ -48,7 +46,6 @@ try: libXext.XCloseDisplay(display) return state - dpms_loaded = True except Exception: pass diff --git a/panels/bed_mesh.py b/panels/bed_mesh.py index 9d5e84aa..a2e81ae0 100644 --- a/panels/bed_mesh.py +++ b/panels/bed_mesh.py @@ -142,7 +142,6 @@ class BedMeshPanel(ScreenPanel): button_box.add(buttons["load"]) button_box.add(buttons["view"]) - box = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL, spacing=5) box.pack_start(name, True, True, 0) box.pack_start(button_box, False, False, 0) @@ -177,7 +176,6 @@ class BedMeshPanel(ScreenPanel): return True return False - def load_meshes(self): bm_profiles = self._screen.printer.get_config_section_list("bed_mesh ") logging.info(f"Bed profiles: {bm_profiles}") diff --git a/scripts/check_code.sh b/scripts/check_code.sh index 2707e6ed..d86a4c91 100755 --- a/scripts/check_code.sh +++ b/scripts/check_code.sh @@ -1,3 +1,3 @@ #!/bin/bash -pycodestyle --ignore=E226,E301,E302,E303,E402,W503,W504 --max-line-length=120 --max-doc-length=120 screen.py ks_includes panels +pycodestyle --ignore=E402,W503,W504 --max-line-length=120 --max-doc-length=120 screen.py ks_includes panels